Github user mridulm commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184625003
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -107,9 +109,16 @@ public HiveAuthFactory(HiveConf conf) throws
TTransportException {
authTypeStr = AuthTypes.NONE.getAuthName();
}
if (authTypeStr.equalsIgnoreCase(AuthTypes.KERBEROS.getAuthName())) {
- saslServer = ShimLoader.getHadoopThriftAuthBridge()
- .createServer(conf.getVar(ConfVars.HIVE_SERVER2_KERBEROS_KEYTAB),
-
conf.getVar(ConfVars.HIVE_SERVER2_KERBEROS_PRINCIPAL));
+ String principal =
conf.getVar(ConfVars.HIVE_SERVER2_KERBEROS_PRINCIPAL);
+ String keytab = conf.getVar(ConfVars.HIVE_SERVER2_KERBEROS_KEYTAB);
+ if (needUgiLogin(UserGroupInformation.getCurrentUser(),
+ SecurityUtil.getServerPrincipal(principal, "0.0.0.0"), keytab)) {
--- End diff --
This will always return `false` : though the additional check will not hurt.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
