Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21133#discussion_r184654618
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/ApproximatePercentile.scala
---
@@ -238,12 +238,6 @@ object ApproximatePercentile {
summaries = summaries.insert(value)
// The result of QuantileSummaries.insert is un-compressed
isCompressed = false
-
- // Currently, QuantileSummaries ignores the construction parameter
compressThresHold,
- // which may cause QuantileSummaries to occupy unbounded memory. We
have to hack around here
- // to make sure QuantileSummaries doesn't occupy infinite memory.
- // TODO: Figure out why QuantileSummaries ignores construction
parameter compressThresHold
- if (summaries.sampled.length >= compressThresHoldBufferLength)
compress()
--- End diff --
no problem at all, thanks for checking this :) I addressed you comment on
the test. Any more comments?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
