Github user huaxingao commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21119#discussion_r184808830
  
    --- Diff: python/pyspark/ml/clustering.py ---
    @@ -1156,6 +1156,201 @@ def getKeepLastCheckpoint(self):
             return self.getOrDefault(self.keepLastCheckpoint)
     
     
    +class _PowerIterationClusteringParams(JavaParams, HasMaxIter, 
HasPredictionCol):
    --- End diff --
    
    @WeichenXu123 Thanks for your review. The params can be either inside class 
PowerIterationClustering or separate. I will move them back inside class 
PowerIterationClustering, to be consistent with the params in the other classes 
in clustering. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to