Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21145#discussion_r185302250
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchReader.scala
---
@@ -299,13 +299,13 @@ private[kafka010] class KafkaMicroBatchReader(
}
}
-/** A [[DataReaderFactory]] for reading Kafka data in a micro-batch
streaming query. */
+/** A [[ReadTask]] for reading Kafka data in a micro-batch streaming
query. */
private[kafka010] case class KafkaMicroBatchDataReaderFactory(
--- End diff --
Yes. This kind of changes always become unnecessarily big. Since this PR
turns the master branch into an inconsistent state, could you make a JIRA issue
for the remaining tasks which this PR avoids? Then, someone else can help
Apache Spark become more consistent later eventually in Apache Spark 2.4 (or
3.0) timeframe.
> I think we should avoid requiring changes to make everything consistent
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
