Github user mn-mikke commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21208#discussion_r185534457
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
 ---
    @@ -1229,3 +1229,98 @@ case class Flatten(child: Expression) extends 
UnaryExpression {
     
       override def prettyName: String = "flatten"
     }
    +
    +/**
    + * Returns the array containing the given input value (left) count (right) 
times.
    + */
    +@ExpressionDescription(
    +  usage = "_FUNC_(element, count) - Returns the array containing element 
count times.",
    +  examples = """
    +    Examples:
    +      > SELECT _FUNC_('123', 2);
    +       ['123', '123']
    +  """)
    +case class ArrayRepeat(left: Expression, right: Expression)
    +  extends BinaryExpression {
    +
    +  override def dataType: ArrayType = ArrayType(left.dataType, 
left.nullable)
    +
    +  override def checkInputDataTypes(): TypeCheckResult = {
    +    val expected = IntegerType
    +    if (!expected.acceptsType(right.dataType)) {
    +      val mismatch = s"argument 2 requires ${expected.simpleString} type, 
" +
    +        s"however, '${right.sql}' is of ${right.dataType.simpleString} 
type."
    +      TypeCheckResult.TypeCheckFailure(mismatch)
    +    } else {
    +      TypeCheckResult.TypeCheckSuccess
    +    }
    +  }
    +
    +  override def nullable: Boolean = false
    --- End diff --
    
    What about cases when `right` is evaluated to `null`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to