Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21193#discussion_r185761453
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -120,13 +216,15 @@ object JavaCode {
trait ExprValue extends JavaCode {
def javaType: Class[_]
def isPrimitive: Boolean = javaType.isPrimitive
+
+ // This will be called during string interpolation.
+ override def toString: String = ExprValue.exprValueToString(this)
}
object ExprValue {
- implicit def exprValueToString(exprValue: ExprValue): String =
exprValue.toString
+ implicit def exprValueToString(exprValue: ExprValue): String =
exprValue.code
--- End diff --
why can't we use `toString`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
