Github user brkyvz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21220#discussion_r185896682
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSinkSuite.scala
 ---
    @@ -279,13 +279,10 @@ class FileStreamSinkSuite extends StreamTest {
           check() // nothing emitted yet
     
           addTimestamp(104, 123) // watermark = 90 before this, watermark = 
123 - 10 = 113 after this
    -      check() // nothing emitted yet
    +      check((100L, 105L) -> 2L)  // no-data-batch emits results on 100-105,
    --- End diff --
    
    I would explicitly test with flag on for this. in case we want to turn it 
off, this test shouldn't fail


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to