Github user rdblue commented on the issue:
https://github.com/apache/spark/pull/21118
@cloud-fan, actually I tried a lot of different queries yesterday,
including joins and aggregations. The only thing that didn't work was `collect`
for a `select * from t` because `SparkPlan` assumes that the [rows will be
unsafe](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala#L254).
I'm planning to do more testing, but I don't see anything that requires
`UnsafeRow` in generated code. @marmbrus, what was the original intent in
codegen? Should codegen use `InternalRow` or `UnsafeRow`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
