Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/18801#discussion_r186160092
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitUtilsSuite.scala ---
@@ -255,4 +256,20 @@ class SparkSubmitUtilsSuite extends SparkFunSuite with
BeforeAndAfterAll {
assert(jarPath.indexOf("mydep") >= 0, "should find dependency")
}
}
+
+ test("test resolution files cleaned after resolving artifact") {
--- End diff --
Actually triggering the original race in a test could be pretty hard, so
I'm not sure that we necessarily should block this fix on having an end-to-end
integration test which could reproduce the original race. I think that the use
of the UUID should be sufficient and therefore the only important thing to test
is that we're still cleaning up the files properly (as is being done here).
Therefore I would welcome a re-submitted and cleaned-up version of this PR
which addresses the other review comments (which I hope to merge soon if it's
in good shape).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
