GitHub user dbtsai opened a pull request:

    https://github.com/apache/spark/pull/21235

    [SPARK-24181][SQL] Better error message for writing sorted data

    ## What changes were proposed in this pull request?
    
    The exception message should clearly distinguish sorting and bucketing in 
`save` and `jdbc` write.
    
    When a user tries to write a sorted data using save or insertInto, it will 
throw an exception with message that `s"'$operation' does not support bucketing 
right now""`. 
    
    We should throw `s"'$operation' does not support sorting right now""` 
instead.
    
    ## How was this patch tested?
    
    More tests in `DataFrameReaderWriterSuite.scala`


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dbtsai/spark fixException

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21235.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21235
    
----
commit 72efec10871ed15eb1bef8b208f9b08de1191456
Author: DB Tsai <d_tsai@...>
Date:   2018-04-27T18:53:29Z

    The exception message should clearly distinguish sorting and bucketing in 
save() and jdbc write

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to