Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21028#discussion_r186182632
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -413,6 +413,25 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
         )
       }
     
    +  test("arrays_overlap function") {
    +    val df = Seq(
    +      (Seq[Option[Int]](Some(1), Some(2)), Seq[Option[Int]](Some(-1), 
Some(10))),
    +      (Seq.empty[Option[Int]], Seq[Option[Int]](Some(-1), None)),
    +      (Seq[Option[Int]](Some(3), Some(2)), Seq[Option[Int]](Some(1), 
Some(2)))
    +    ).toDF("a", "b")
    +
    +    val answer = Seq(Row(false), Row(null), Row(true))
    +
    +    checkAnswer(df.select(arrays_overlap(df("a"), df("b"))), answer)
    +    checkAnswer(df.selectExpr("arrays_overlap(a, b)"), answer)
    +
    +    checkAnswer(sql("select arrays_overlap(array(1, 2, 3), array('a', 'b', 
'c'))"), Row(false))
    +
    --- End diff --
    
    Honestly I don't see its utility but I see also no harm in introducing it, 
so if you think it is a added value, I think it is fine to add it. So I just 
added it, thanks.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to