Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21192#discussion_r186284300
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JSONOptions.scala
---
@@ -120,8 +120,26 @@ private[sql] class JSONOptions(
enc
}
- val lineSeparatorInRead: Option[Array[Byte]] = lineSeparator.map {
lineSep =>
- lineSep.getBytes(encoding.getOrElse("UTF-8"))
+ /**
+ * A sequence of bytes between two consecutive json records in read.
+ * Format of the `lineSep` option is:
+ * selector (1 char) + separator spec (any length) | sequence of chars
+ *
+ * Currently the following selectors are supported:
+ * - 'x' + sequence of bytes in hexadecimal format. For example: "x0a
0d".
--- End diff --
Yes, that's what I thought and I hope the sequence of bytes alone is taken
out here if you won't mind. In this case, I don't want to block this PR too
likewise.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
