Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21106#discussion_r186630383
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -686,6 +687,17 @@ object SQLConf {
         .intConf
         .createWithDefault(100)
     
    +  val CODEGEN_OBJECT_FALLBACK = 
buildConf("spark.sql.test.codegenObject.fallback")
    --- End diff --
    
    hmm, shall we use `CODEGEN_FACTORY_MODE` or `CODEGEN_FALLBACK_MODE`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to