Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/21268
@jerryshao I don't think we can miss them. The main change here is the
`uiRoot` requires the `request` object. So if you miss to provide it the
object, it doesn't compile. All the other changes are just for passing the
`request` object where it is needed.
The main advantage is that this change allows to connect to SHS both via
Knox gateway and via direct URL. Using `spark.ui.proxyBase`, you can support
Knox setting it for instance to `gateway/default/sparkhistoryui`. When you do
this, if you access SHS via direct URL, it won't work. So you can't access SHS
successfully both via Knox gateway and via the direct URL. This change allows
this to happen instead.
Another minor advantage is that (for the same reason) we can support
multiple Knox gateway to proxy SHS.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
