Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21246#discussion_r186999333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala
---
@@ -0,0 +1,534 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.expressions
+
+import org.apache.commons.codec.digest.DigestUtils
+
+import org.apache.spark.sql.AnalysisException
+import org.apache.spark.sql.catalyst.expressions.MaskExpressionsUtils._
+import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext,
CodeGenerator, ExprCode}
+import org.apache.spark.sql.types._
+import org.apache.spark.unsafe.types.UTF8String
+
+
+trait MaskLike {
+ val defaultMaskedUppercase: Int = 'X'
+ val defaultMaskedLowercase: Int = 'x'
+ val defaultMaskedDigit: Int = 'n'
+ val defaultMaskedOther: Int = MaskExpressionsUtils.UNMASKED_VAL
+
+ def upper: String
+ def lower: String
+ def digit: String
+
+ protected lazy val upperReplacement: Int = getReplacementChar(upper,
defaultMaskedUppercase)
+ protected lazy val lowerReplacement: Int = getReplacementChar(lower,
defaultMaskedLowercase)
+ protected lazy val digitReplacement: Int = getReplacementChar(digit,
defaultMaskedDigit)
+
+ protected val maskUtilsClassName: String =
classOf[MaskExpressionsUtils].getName
+
+ def maskAndAppendToStringBuilderCode(
+ ctx: CodegenContext,
+ sb: String,
+ inputString: String,
+ start: String,
+ end: String): String = {
+ val i = ctx.freshName("i")
+ s"""
+ |for (${CodeGenerator.JAVA_INT} $i = $start; $i < $end; $i ++) {
+ |
$sb.appendCodePoint($maskUtilsClassName.transformChar($inputString.charAt($i),
--- End diff --
`codePointAt()` instead of `charAt()`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
