Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/21218#discussion_r187115704
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/clustering/BisectingKMeans.scala ---
@@ -278,6 +279,7 @@ class BisectingKMeans @Since("2.0.0") (
val summary = new BisectingKMeansSummary(
model.transform(dataset), $(predictionCol), $(featuresCol), $(k))
model.setSummary(Some(summary))
+ instr.logNamedValue("clusterSizes", summary.clusterSizes.mkString(",
"))
--- End diff --
We log Params in JSON format, but we don't have a precedent for logging
Array values. I'd be OK with ducking the issue by not logging this value, or
with logging it as JSON. If the latter, then we could add a method
Instrumentation.logNamedValue taking Array types.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
