Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21280#discussion_r187194900
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/SparkListenerSuite.scala ---
    @@ -583,3 +587,23 @@ private class 
FirehoseListenerThatAcceptsSparkConf(conf: SparkConf) extends Spar
         case _ =>
       }
     }
    +
    +private class SlowDeserializable(var readDuration: Int)
    --- End diff --
    
    Probably easier to make the sleep time hardcoded? Then a lot of this code 
goes away.
    
    (And if doing that, the `@throws` annotations are most probably 
unnecessary.)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to