Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/21255#discussion_r187238518
--- Diff: R/pkg/R/functions.R ---
@@ -219,7 +219,8 @@ NULL
#' head(select(tmp3, map_values(tmp3$v3)))
#' head(select(tmp3, element_at(tmp3$v3, "Valiant")))
#' tmp4 <- mutate(df, v4 = create_array(df$mpg, df$cyl), v5 =
create_array(df$hp))
-#' head(select(tmp4, concat(tmp4$v4, tmp4$v5)))}
+#' head(select(tmp4, concat(tmp4$v4, tmp4$v5)))
+#' concat(df$mpg, df$cyl, df$hp)}
--- End diff --
I'd perhaps do this as
```
tmp5 <- mutate(df, s1 = concat(df$mpg, df$cyl, df$hp)
head(tmp5)
```
or
```
head(mutate(df, s1 = concat(df$mpg, df$cyl, df$hp))
```
btw, aren't these numeric columns? does that work with concat?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
