Github user fangshil commented on a diff in the pull request:
https://github.com/apache/spark/pull/21276#discussion_r187263297
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/TypedAggregateExpression.scala
---
@@ -109,7 +110,8 @@ trait TypedAggregateExpression extends
AggregateFunction {
s"$nodeName($input)"
}
- override def nodeName: String =
aggregator.getClass.getSimpleName.stripSuffix("$")
+ // Utils.getSimpleName is safer than aggregator.getClass.getSimpleName
in scala.
--- End diff --
updated comments
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]