Github user shivaram commented on a diff in the pull request:
https://github.com/apache/spark/pull/21278#discussion_r187470922
--- Diff: R/pkg/R/client.R ---
@@ -60,13 +60,48 @@ generateSparkSubmitArgs <- function(args, sparkHome,
jars, sparkSubmitOpts, pack
combinedArgs
}
+checkJavaVersion <- function() {
+ javaBin <- "java"
+ javaHome <- Sys.getenv("JAVA_HOME")
+ javaReqs <- utils::packageDescription(utils::packageName(),
fields=c("SystemRequirements"))
+ sparkJavaVersion <- as.numeric(tail(strsplit(javaReqs, "[(=)]")[[1]], n
= 1L))
+ if (javaHome != "") {
+ javaBin <- file.path(javaHome, "bin", javaBin)
--- End diff --
Yes. If you look at
https://github.com/apache/spark/blob/d3c426a5b02abdec49ff45df12a8f11f9e473a88/bin/spark-class2.cmd#L54
we append `bin`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
