Github user fangshil commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21276#discussion_r187518454
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -2715,6 +2715,66 @@ private[spark] object Utils extends Logging {
         HashCodes.fromBytes(secretBytes).toString()
       }
     
    +  /**
    +   * A safer version than scala obj's getClass.getSimpleName and 
Utils.getFormattedClassName
    +   * which may throw Malformed class name error.
    +   * This method mimicks scalatest's getSimpleNameOfAnObjectsClass.
    +   */
    +  def getSimpleName(fullyQualifiedName: String): String = {
    --- End diff --
    
    a if statement to determine if the name is good or not may not be stable 
and comprehensive - how about we use try-catch here and only use the 
alternative if obj.getClass.getSimpleName throws the Malformed class name error


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to