Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21299#discussion_r187787083
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/CreateJacksonParser.scala
---
@@ -78,17 +78,4 @@ private[sql] object CreateJacksonParser extends
Serializable {
def inputStream(enc: String, jsonFactory: JsonFactory, is: InputStream):
JsonParser = {
jsonFactory.createParser(new InputStreamReader(is, enc))
}
-
- def internalRow(jsonFactory: JsonFactory, row: InternalRow): JsonParser
= {
- val ba = row.getBinary(0)
-
- jsonFactory.createParser(ba, 0, ba.length)
- }
-
- def internalRow(enc: String, jsonFactory: JsonFactory, row:
InternalRow): JsonParser = {
- val binary = row.getBinary(0)
- val sd = getStreamDecoder(enc, binary, binary.length)
-
- jsonFactory.createParser(sd)
- }
--- End diff --
Why these two removed? Looks like no SQLConf involved here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
