Github user zheh12 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r187960677
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -120,7 +120,8 @@ abstract class FileCommitProtocol {
* Specifies that a file should be deleted with the commit of this job.
The default
* implementation deletes the file immediately.
*/
- def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean):
Boolean = {
+ def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean,
--- End diff --
In the current situation we can delete it, but I feel it better to use a
default value true.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
