Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/21183#discussion_r188779768
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/clustering/LDASuite.scala ---
@@ -253,6 +253,14 @@ class LDASuite extends SparkFunSuite with
MLlibTestSparkContext with DefaultRead
val lda = new LDA()
testEstimatorAndModelReadWrite(lda, dataset, LDASuite.allParamSettings,
LDASuite.allParamSettings, checkModelData)
+
+ def checkModelDataWithDataset(model: LDAModel, model2: LDAModel,
dataset: Dataset[_]): Unit = {
--- End diff --
* We don't need this inline method.
* Leave a comment to explain why we are doing this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
