Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21291#discussion_r188868610
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/debug/DebuggingSuite.scala
 ---
    @@ -34,14 +34,13 @@ class DebuggingSuite extends SparkFunSuite with 
SharedSQLContext {
     
       test("debugCodegen") {
         val res = 
codegenString(spark.range(10).groupBy("id").count().queryExecution.executedPlan)
    --- End diff --
    
    can we change to `groupBy('id * 2)`? We should try our best to keep what to 
test, and keep 2 the shuffle in this query.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to