Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20894#discussion_r189065416
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
 ---
    @@ -1368,4 +1370,123 @@ class CSVSuite extends QueryTest with 
SharedSQLContext with SQLTestUtils with Te
           checkAnswer(computed, expected)
         }
       }
    +
    +  def checkHeader(multiLine: Boolean): Unit = {
    +    withSQLConf(SQLConf.CASE_SENSITIVE.key -> "true") {
    +      withTempPath { path =>
    +        val oschema = new StructType().add("f1", DoubleType).add("f2", 
DoubleType)
    +        val odf = spark.createDataFrame(List(Row(1.0, 1234.5)).asJava, 
oschema)
    +        odf.write.option("header", true).csv(path.getCanonicalPath)
    +        val ischema = new StructType().add("f2", DoubleType).add("f1", 
DoubleType)
    +        val exception = intercept[SparkException] {
    +          spark.read
    +            .schema(ischema)
    +            .option("multiLine", multiLine)
    +            .option("header", true)
    +            .option("enforceSchema", false)
    +            .csv(path.getCanonicalPath)
    +            .collect()
    +        }
    +        assert(exception.getMessage.contains(
    +          "CSV header is not conform to the schema"
    +        ))
    --- End diff --
    
    tiny nit: shell we make this inlined if we need more other changes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to