Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21337#discussion_r189125545
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/continuous/shuffle/ContinuousShuffleReadRDD.scala
 ---
    @@ -0,0 +1,67 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.streaming.continuous.shuffle
    +
    +import java.util.UUID
    +
    +import org.apache.spark.{Partition, SparkContext, SparkEnv, TaskContext}
    +import org.apache.spark.rdd.RDD
    +import org.apache.spark.sql.catalyst.expressions.UnsafeRow
    +import org.apache.spark.sql.internal.SQLConf
    +import org.apache.spark.util.NextIterator
    +
    +case class ContinuousShuffleReadPartition(index: Int) extends Partition {
    +  // Initialized only on the executor, and only once even as we call 
compute() multiple times.
    +  lazy val (receiver, endpoint) = {
    +    val env = SparkEnv.get.rpcEnv
    +    val receiver = new 
UnsafeRowReceiver(SQLConf.get.continuousStreamingExecutorQueueSize, env)
    --- End diff --
    
    It might be more easier to understand the information flow if the queue 
size value is directly passed through the RDD as opposed to magically getting 
it through `SQLConf.get` (hard to debug issues like why is my conf from my 
session not being used).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to