Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2940#issuecomment-61043515
For reference to others, I spoke @pwendell and @JoshRosen offline and
decided that a slightly modified version of suggestion 3 (in my earlier
comment) is the best middle ground that addresses all the concerns. What I have
done is add a trait `ReceivedBlockStoreResult`.
`ReceivedBlockHandler.storeBlock` returns a `ReceivedBlockStoreResult` object,
the contents of that object is not of any concern to `ReceiverSupervisorImpl`
and simply passed on. Implementations of `ReceivedBlockHandler` all return
`ReceivedBlockStoreResult`, so no generic typing. This keeps the complexity
low, while keeping `ReceiverSupervisorImpl` code generic, and addressing
Patrick's concern of `Option[Any]` being non-intuitive.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
