Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21331#discussion_r189411116
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
---
@@ -85,6 +87,14 @@ object Canonicalize {
case Not(GreaterThanOrEqual(l, r)) => LessThan(l, r)
case Not(LessThanOrEqual(l, r)) => GreaterThan(l, r)
+ // order the list in the In operator
+ // we can do this only if all the elements in the list are literals
with the same datatype
+ case i @ In(value, list)
+ if i.inSetConvertible &&
list.map(_.dataType.asNullable).distinct.size == 1 =>
--- End diff --
Does isSetConvertable accept that? Also, does your example works with the
very next line `val literals = list.map(_.asInstanceOf[Literal])`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
