Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/21369#discussion_r189438351
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -585,17 +592,15 @@ class ExternalAppendOnlyMap[K, V, C](
} else {
logInfo(s"Task ${context.taskAttemptId} force spilling in-memory
map to disk and " +
s"it will release
${org.apache.spark.util.Utils.bytesToString(getUsed())} memory")
- nextUpstream = spillMemoryIteratorToDisk(upstream)
+ val nextUpstream = spillMemoryIteratorToDisk(upstream)
+ assert(!upstream.hasNext)
hasSpilled = true
+ upstream = nextUpstream
--- End diff --
Basically yes, according to my understanding of the code this should have
happened on the subsequent hasNext/next call. However according to the analysis
in the jira the iterator kept holding this reference, my guess: at this point
the entire program started suffering lengthy GC pauses that got it into
behaving as if under a deadlock,effectively leaving the ref in place (just a
guess)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
