Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21376#discussion_r189458452
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/internal/ExecutorSideSQLConfSuite.scala
 ---
    @@ -0,0 +1,66 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.internal
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.SparkSession
    +import org.apache.spark.sql.test.SQLTestUtils
    +
    +class ExecutorSideSQLConfSuite extends SparkFunSuite with SQLTestUtils {
    +  import testImplicits._
    +
    +  protected var spark: SparkSession = null
    +
    +  // Create a new [[SparkSession]] running in local-cluster mode.
    +  override def beforeAll(): Unit = {
    +    super.beforeAll()
    +    spark = SparkSession.builder()
    +      .master("local-cluster[2,1,1024]")
    +      .appName("testing")
    +      .getOrCreate()
    +  }
    +
    +  override def afterAll(): Unit = {
    +    spark.stop()
    +    spark = null
    +  }
    +
    +  test("ReadonlySQLConf is correctly created at the executor side") {
    --- End diff --
    
    nit: `ReadOnlySQLConf `


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to