Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21376#discussion_r189465557
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -107,7 +107,20 @@ object SQLConf {
        * run tests in parallel. At the time this feature was implemented, this 
was a no-op since we
        * run unit tests (that does not involve SparkSession) in serial order.
        */
    -  def get: SQLConf = confGetter.get()()
    +  def get: SQLConf = {
    +    if (TaskContext.get != null) {
    +      new ReadOnlySQLConf(TaskContext.get())
    +    } else {
    +      if (Utils.isTesting && SparkContext.getActive.isDefined) {
    --- End diff --
    
    good check!!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to