Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21331#discussion_r189488666
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Canonicalize.scala
 ---
    @@ -85,6 +87,14 @@ object Canonicalize {
         case Not(GreaterThanOrEqual(l, r)) => LessThan(l, r)
         case Not(LessThanOrEqual(l, r)) => GreaterThan(l, r)
     
    +    // order the list in the In operator
    +    // we can do this only if all the elements in the list are literals 
with the same datatype
    +    case i @ In(value, list)
    +        if i.inSetConvertible && 
list.map(_.dataType.asNullable).distinct.size == 1 =>
    +      val literals = list.map(_.asInstanceOf[Literal])
    +      val ordering = 
TypeUtils.getInterpretedOrdering(literals.head.dataType)
    --- End diff --
    
    For non-ordering type, this will throw match error.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to