Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21361#discussion_r189598693
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -74,6 +74,10 @@ class DataFrameSuite extends QueryTest with 
SharedSQLContext {
         assert(complexData.filter(complexData("a").getItem(0) === 2).count() 
== 1)
         assert(complexData.filter(complexData("m").getItem("1") === 1).count() 
== 1)
         assert(complexData.filter(complexData("s").getField("key") === 
1).count() == 1)
    +
    +    // SPARK-24313: access binary keys
    --- End diff --
    
    can we create a new test case? I think a correctness bug deserves an 
individual test case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to