Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21356#discussion_r189695936
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
    @@ -130,7 +129,11 @@ private class AsyncEventQueue(val name: String, conf: 
SparkConf, metrics: LiveLi
           eventCount.incrementAndGet()
           eventQueue.put(POISON_PILL)
         }
    -    dispatchThread.join()
    +    // this thread might be trying to stop itself as part of error 
handling -- we can't join
    +    // in that case.
    +    if (Thread.currentThread() != dispatchThread) {
    --- End diff --
    
    it's ok to leave this, but this doesn't happen anymore, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to