Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21257#discussion_r189719775
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/FileCommitProtocol.scala ---
@@ -120,8 +120,9 @@ abstract class FileCommitProtocol {
* Specifies that a file should be deleted with the commit of this job.
The default
* implementation deletes the file immediately.
*/
- def deleteWithJob(fs: FileSystem, path: Path, recursive: Boolean):
Boolean = {
- fs.delete(path, recursive)
+ def deleteWithJob(fs: FileSystem, path: Path,
+ canDeleteNow: Boolean = true): Boolean = {
--- End diff --
Nit: style issue. Can we follow the indents in the method declaration?
https://github.com/databricks/scala-style-guide#spacing-and-indentation
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
