Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21388#discussion_r189757355
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala 
---
    @@ -703,6 +703,33 @@ object ScalaReflection extends ScalaReflection {
        */
       def getClassFromType(tpe: Type): Class[_] = 
mirror.runtimeClass(tpe.dealias.typeSymbol.asClass)
     
    +  def getClassFromTypeHandleArray(tpe: Type): Class[_] = 
cleanUpReflectionObjects {
    +    tpe.dealias match {
    +      case ty if ty <:< localTypeOf[Array[_]] =>
    +        def arrayClassFromType(tpe: `Type`): Class[_] =
    --- End diff --
    
    hmm .. Could we avoid this nested function? 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to