Github user advancedxy commented on a diff in the pull request:
https://github.com/apache/spark/pull/21369#discussion_r189768075
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -305,8 +310,8 @@ class ExternalAppendOnlyMap[K, V, C](
// Input streams are derived both from the in-memory map and spilled
maps on disk
// The in-memory map is sorted in place, while the spilled maps are
already in sorted order
- private val sortedMap = CompletionIterator[(K, C), Iterator[(K,
C)]](destructiveIterator(
- currentMap.destructiveSortedIterator(keyComparator)),
freeCurrentMap())
+ private val sortedMap = destructiveIterator(
+ currentMap.destructiveSortedIterator(keyComparator))
--- End diff --
These two lines can be merged into one line?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
