Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21106#discussion_r189840863
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/UnsafeRowConverterSuite.scala
---
@@ -24,25 +24,30 @@ import org.scalatest.Matchers
import org.apache.spark.SparkFunSuite
import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.plans.PlanTestBase
import org.apache.spark.sql.catalyst.util._
+import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.{IntegerType, LongType, _}
import org.apache.spark.unsafe.array.ByteArrayMethods
import org.apache.spark.unsafe.types.UTF8String
-class UnsafeRowConverterSuite extends SparkFunSuite with Matchers {
+class UnsafeRowConverterSuite extends SparkFunSuite with Matchers with
PlanTestBase {
private def roundedSize(size: Int) =
ByteArrayMethods.roundNumberOfBytesToNearestWord(size)
- private def testWithFactory(
- name: String)(
- f: UnsafeProjectionCreator => Unit): Unit = {
- test(name) {
- f(UnsafeProjection)
- f(InterpretedUnsafeProjection)
+ private def testBothCodegenAndInterpreted(name: String)(f: => Unit):
Unit = {
+ val modes = Seq(CodegenObjectFactoryMode.CODEGEN_ONLY,
CodegenObjectFactoryMode.NO_CODEGEN)
+ for (fallbackMode <- modes) {
+ test(name + " with " + fallbackMode) {
--- End diff --
Ok.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
