Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3003#discussion_r19621262
  
    --- Diff: 
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala ---
    @@ -563,6 +563,31 @@ class TaskSetManagerSuite extends FunSuite with 
LocalSparkContext with Logging {
         assert(manager.emittedTaskSizeWarning)
       }
     
    +  test("abort the job if total size of results is too large") {
    +    val conf = new SparkConf().set("spark.driver.maxResultSize", "2m")
    +    sc = new SparkContext("local", "test", conf)
    +
    +    // multiple tiny result
    +    val r = sc.makeRDD(0 until (1 << 10), 10).collect()
    +    assert((1 << 10) === r.size )
    +
    +    // single large result
    +    try {
    +      sc.makeRDD(0 until (1<<20), 1).collect()
    +      throw new Exception("single large result should fail")
    +    } catch {
    +      case e: SparkException =>
    +    }
    --- End diff --
    
    Instead of this pattern, you can use
    ```
    intercept[SparkException] { sc.makeRDD(...).collect() }
    ```
    This is provided by ScalaTest and expects that exception.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to