Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21311#discussion_r189878180
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/HashedRelation.scala
 ---
    @@ -626,6 +618,32 @@ private[execution] final class LongToUnsafeRowMap(val 
mm: TaskMemoryManager, cap
         }
       }
     
    +  private def grow(neededSize: Int): Unit = {
    +    // There is 8 bytes for the pointer to next value
    +    val totalNeededSize = cursor + 8 + neededSize
    --- End diff --
    
    nit:
    ```
    private def grow(inputRowSize: Int): Unit = {
      val neededSize = cursor + 8 + inputRowSize
      val currentSize = page.length * 8L + Platform.LONG_ARRAY_OFFSET
      ...
    }
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to