Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/21369#discussion_r189921783
--- Diff:
core/src/test/scala/org/apache/spark/util/collection/ExternalAppendOnlyMapSuite.scala
---
@@ -414,6 +415,99 @@ class ExternalAppendOnlyMapSuite extends SparkFunSuite
with LocalSparkContext {
sc.stop()
}
+ test("spill during iteration") {
--- End diff --
This test was written BEFORE the actual fix and it did fail up untill the
fix was in place. I do agree it's a bit clumsy and potential future changes may
break the original intention of the test. I've referred a potential testing
approach (currently limited to scala's source code) which couldn't be (easily)
applied to this code base so I made a best effort to test this.
I agree this needs better documentation, I'll start be referring the issue
in the test's name and will also add comments to the code.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
