Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21393#discussion_r189945980
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/PrefixSpan.scala ---
    @@ -63,26 +135,22 @@ object PrefixSpan {
       @Since("2.4.0")
       def findFrequentSequentialPatterns(
           dataset: Dataset[_],
    -      sequenceCol: String,
    -      minSupport: Double,
    -      maxPatternLength: Int,
    -      maxLocalProjDBSize: Long): DataFrame = {
    +      sequenceCol: String): DataFrame = {
    --- End diff --
    
    Why not making it a param?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to