Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21295#discussion_r189957937
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetQuerySuite.scala
 ---
    @@ -879,6 +879,18 @@ class ParquetQuerySuite extends QueryTest with 
ParquetTest with SharedSQLContext
           }
         }
       }
    +
    +  test("SPARK-24230: filter row group using dictionary") {
    +    withSQLConf(("parquet.filter.dictionary.enabled", "true")) {
    --- End diff --
    
    That was my point, too. This configuration is needed, but this code doesn't 
do anything for that. To use this configuration correctly, we need to fix it 
first. We should not have no-op code like this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to