Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21389#discussion_r189961194
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
 ---
    @@ -2408,4 +2409,53 @@ class JsonSuite extends QueryTest with 
SharedSQLContext with TestJsonData {
           spark.read.option("mode", "PERMISSIVE").option("encoding", 
"UTF-8").json(Seq(badJson).toDS()),
           Row(badJson))
       }
    +
    +  test("SPARK-24204 error handling for unsupported data types") {
    --- End diff --
    
    (Probably, the suggestion is related to the one above) Essentially, the 
supported types are specific to datasource implementations, so I'm not 100% 
sure that it's the best to put these tests in `FileBasedDataSourceSuite `.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to