Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/21092#discussion_r189982571
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -54,7 +54,8 @@ private[spark] class BasicExecutorFeatureStep(
private val memoryOverheadMiB = kubernetesConf
.get(EXECUTOR_MEMORY_OVERHEAD)
- .getOrElse(math.max((MEMORY_OVERHEAD_FACTOR * executorMemoryMiB).toInt,
+ .getOrElse(math.max(
+ (kubernetesConf.get(MEMORY_OVERHEAD_FACTOR).getOrElse(0.1) *
executorMemoryMiB).toInt,
--- End diff --
Yeah so multiple yes, but since have two instances of this magic 0.1
constant I'd rather have it shared somewhere incase we go to update this in the
future and don't get everywhere. Could also be a shared constant if we want
instead rather than a getter for memory overhead factor, either way keeps us
honest.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
