Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/21385#discussion_r190082630
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/shuffle/ContinuousShuffleReadSuite.scala
---
@@ -161,13 +189,15 @@ class ContinuousShuffleReadSuite extends StreamTest {
test("blocks waiting for new rows") {
val rdd = new ContinuousShuffleReadRDD(sparkContext, numPartitions = 1)
+ val epoch = rdd.compute(rdd.partitions(0), ctx)
val readRowThread = new Thread {
override def run(): Unit = {
- // set the non-inheritable thread local
- TaskContext.setTaskContext(ctx)
- val epoch = rdd.compute(rdd.partitions(0), ctx)
- epoch.next().getInt(0)
+ try {
--- End diff --
okay. that make sense. I was worried it was for some nasty error condition
that i missed in the previous PR review.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
