Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21390#discussion_r190098624
--- Diff: core/src/main/scala/org/apache/spark/deploy/worker/Worker.scala
---
@@ -732,6 +736,9 @@ private[deploy] class Worker(
trimFinishedExecutorsIfNecessary()
coresUsed -= executor.cores
memoryUsed -= executor.memory
+ if (CLEANUP_NON_SHUFFLE_FILES_ENABLED) {
+
shuffleService.executorRemoved(executorStateChanged.execId.toString, appId)
--- End diff --
It takes me great pain to name a function, config, etc, so I just followed
the existing similar pattern. Thus, I'm happy to rename them, perhaps
`cleanupNonshuffleFilesOfExecutor`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
