Github user galv commented on a diff in the pull request:
https://github.com/apache/spark/pull/20761#discussion_r190104076
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -249,6 +259,10 @@ private[spark] class Client(
val capability = Records.newRecord(classOf[Resource])
capability.setMemory(amMemory + amMemoryOverhead)
capability.setVirtualCores(amCores)
+ if (amResources.nonEmpty) {
--- End diff --
Nitpick: I would execute
`ResourceTypeHelper.setResourceInfoFromResourceTypes(amResources, capability)`
unconditionally. That's just my style, though.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
