Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/21389#discussion_r190130347
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala
---
@@ -89,6 +89,8 @@ class OrcFileFormat
job: Job,
options: Map[String, String],
dataSchema: StructType): OutputWriterFactory = {
+ DataSourceUtils.verifySchema("ORC", dataSchema)
--- End diff --
Thank you for refactoring the PR, @maropu ! What about using `shortName`
instead of string literal "ORC" here? Then, we can have the same line like the
following.
```
DataSourceUtils.verifySchema(shortName, dataSchema)
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
